Skip to content

Foxed build#7

Merged
mitchelsellers merged 2 commits intomasterfrom
feature/dnn-10-support
May 16, 2025
Merged

Foxed build#7
mitchelsellers merged 2 commits intomasterfrom
feature/dnn-10-support

Conversation

@mitchelsellers
Copy link
Contributor

@mitchelsellers mitchelsellers commented May 16, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated workflow to trigger on the master branch instead of develop.
    • Improved build process for DNN extensions with a new, fully self-contained workflow.
    • Installer files are now automatically collected and uploaded as artifacts for easier access.

@mitchelsellers mitchelsellers merged commit e78cde1 into master May 16, 2025
1 check passed
@mitchelsellers mitchelsellers deleted the feature/dnn-10-support branch May 16, 2025 16:43
@coderabbitai
Copy link

coderabbitai bot commented May 16, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

"""

Walkthrough

The GitHub Actions workflow for continuous integration now triggers on the master branch instead of develop. The previous external build_dnn job was removed and replaced by a new self-contained Windows job that explicitly performs checkout, MSBuild setup, NuGet restore, solution build, installer collection, and artifact upload.

Changes

File(s) Change Summary
.github/workflows/ci-dnn.yml Changed workflow triggers from develop to master; removed external build_dnn job; added new Windows-based build_and_store_dnn_extensions job with explicit steps for checkout, MSBuild setup, NuGet restore, build, installer collection, and artifact upload.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub
    participant Runner (Windows)
    participant MSBuild
    participant PowerShell

    GitHub->>Runner (Windows): Trigger workflow on push/pull_request to master
    Runner (Windows)->>Runner (Windows): Checkout repository (full history)
    Runner (Windows)->>Runner (Windows): Setup MSBuild
    Runner (Windows)->>Runner (Windows): Restore NuGet packages
    Runner (Windows)->>MSBuild: Build solution (Release)
    alt Not a pull_request event
        Runner (Windows)->>PowerShell: Collect installer zip files to installers/
        Runner (Windows)->>GitHub: Upload installers as artifact (5 days retention)
    end
Loading

Poem

🐇
On master’s branch the builds now run,
Windows steps shine like the sun.
No shared jobs to borrow or lend,
Installers gathered, zipped to send.
Five days safe in artifact’s care,
CI’s new dance floats on the air!
🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56501dd and 238de3b.

📒 Files selected for processing (1)
  • .github/workflows/ci-dnn.yml (1 hunks)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mitchelsellers

Comments